Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lose VM volume attachments when refreshing the cloud inventory #243

Merged

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Mar 1, 2018

When the CloudManager refreshes, it removes from the inventory any Disks that were only added by the CinderManager as part of attaching Volumes to VMs since the CloudManager doesn't find them while collecting inventory. As a result, Volumes will have correct statuses but incorrect numbers of attachments, leading to confusing user experience and various UI actions failing.
This patch causes the CloudManager to be aware of VM volume attachments so that the associations are not broken between Cloud and Cinder refreshes.

This is a solution for https://bugzilla.redhat.com/show_bug.cgi?id=1544344

Depends on #242

@mansam mansam changed the title Don't lose VM volume attachments when refreshing the cloud inventory [Depends on #242] Don't lose VM volume attachments when refreshing the cloud inventory Mar 1, 2018
@mansam mansam force-pushed the keep-volume-attachments-during-cloud-refresh branch from 588fda4 to 703d1f0 Compare April 19, 2018 18:26
@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2018

Checked commits mansam/manageiq-providers-openstack@d079d62~...703d1f0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 4 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

app/models/manageiq/providers/openstack/inventory/parser/cloud_manager.rb

@mansam mansam changed the title [Depends on #242] Don't lose VM volume attachments when refreshing the cloud inventory Don't lose VM volume attachments when refreshing the cloud inventory Apr 19, 2018
@aufi
Copy link
Member

aufi commented Apr 23, 2018

Looks good to me, merging!

@aufi aufi merged commit ff738f6 into ManageIQ:master Apr 23, 2018
@aufi aufi added the bug label Apr 23, 2018
@aufi aufi added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants