Filter openstack networks without subnets #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of the fix in this PR looks good to me 👍 but let's wait for feedback on ManageIQ/manageiq#17055 |
alexander-demicev
force-pushed
the
eligible-for-provisioning
branch
2 times, most recently
from
022b036 to
69d6ede
Compare
alexander-demicev
force-pushed
the
eligible-for-provisioning
branch
from
69d6ede to
2792017
Compare
alexander-demicev
changed the title
alexander-demicev
force-pushed
the
eligible-for-provisioning
branch
from
2792017 to
653afe7
Compare
|
Looks good to me 👍 |
|
@alexander-demichev It seems that factories for objects using by provision test needs to be updated. |
alexander-demicev
force-pushed
the
eligible-for-provisioning
branch
2 times, most recently
from
2f64eb7 to
aeeabb9
Compare
alexander-demicev
force-pushed
the
eligible-for-provisioning
branch
from
aeeabb9 to
d7adcea
Compare
|
Checked commit alexander-demicev@d7adcea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 20, 2018
…ning Filter openstack networks without subnets (cherry picked from commit 5a855b8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558048
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eligible_for_vm_provisioning method for networks. Network requires a subnet in order to be used for provisioning.
This method is needed for this PR and should fix BZ