Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bz 1546109 fix targeted refresh clearing vm cloud tenant for v2 #233

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Bz 1546109 fix targeted refresh clearing vm cloud tenant for v2 #233

merged 2 commits into from
Feb 19, 2018

Conversation

aufi
Copy link
Member

@aufi aufi commented Feb 19, 2018 •
edited
Loading

To prevent fog-openstack building the wrong query for
.tenants.find_by_id which leads to a 404 error query all tenants during
a targeted refresh.

Adam's PR with VCR reloaded, so tests are passing. #232

agrare and others added 2 commits February 16, 2018 16:29
@agrare
Collect all tenants during vm targeted refresh
ad512db 
To prevent fog-openstack building the wrong query for
.tenants.find_by_id which leads to a 404 error query all tenants during
a targeted refresh.
@aufi
Reload VCRs
918bbff
@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2018

Checked commits aufi/manageiq-providers-openstack@ad512db~...918bbff with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
23 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@aufi aufi mentioned this pull request Feb 19, 2018
Closed
agrare
agrare approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the VCRs @aufi !

@agrare agrare self-assigned this Feb 19, 2018
@agrare agrare merged commit 918bbff into ManageIQ:master Feb 19, 2018
agrare added a commit that referenced this pull request Feb 19, 2018
@agrare
Merge pull request #233 from aufi/bz_1546109_fix_targeted_refresh_cle…
7bb8ea9 
…aring_vm_cloud_tenant_for_v2

Bz 1546109 fix targeted refresh clearing vm cloud tenant for v2
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 19, 2018
@simaishi
Copy link
Contributor

VCRs are conflicting during cherry-pick to gaprindashvili branch. Should I take all VCRs from this PR, ignoring what's there now?

@agrare
Copy link
Member

agrare commented Feb 21, 2018

This still fails with the VCRs from master, looks like will have to be re-recorded to gaprindashvili

@aufi
Copy link
Member Author

aufi commented Feb 21, 2018

I'm going to rerecord VCRs with G-branch.

@aufi
Copy link
Member Author

aufi commented Feb 21, 2018

@agrare VCR rerecord fails for G-branch with and even without the change introduced in this PR, something seems to be broken - http://paste.openstack.org/show/NeM4FFYUMcQj1Yif4DnX/

@agrare
Copy link
Member

agrare commented Feb 21, 2018

cc @Ladas ^^

@Ladas
Copy link
Contributor

Ladas commented Feb 21, 2018

@aufi hm, that code is not in g-branch, is it possible you were trying this on master code by mistake?

@aufi
Copy link
Member Author

aufi commented Feb 21, 2018

@Ladas Thanks, you're right, I have some issues for local config of MIQ/OSP provider repo. @mansam volunteered to rerecord VCRs - Thank you!

@mansam mansam mentioned this pull request Feb 21, 2018
Merged
@simaishi
Copy link
Contributor

Backported to Gaprindashvili via #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aufi @miq-bot @simaishi @agrare @Ladas