Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client to use renamed NetworkDiscovery #227

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Update client to use renamed NetworkDiscovery #227

merged 1 commit into from
Feb 21, 2018

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Feb 13, 2018 •
edited
Loading

ManageIQ/manageiq#16994

Add missing test for the probe method.

@gildub gildub mentioned this pull request Feb 15, 2018
Closed
@gildub
Copy link
Contributor

gildub commented Feb 15, 2018 •
edited
Loading

@jrafanie, I missed this. Anyway the require needs to be updated too per now closed #229

@gildub gildub mentioned this pull request Feb 15, 2018
Closed
14 tasks
@jrafanie jrafanie force-pushed the rename_manageiq_network_to_network_discovery branch from a1f5ac8 to 7efe08f Compare February 15, 2018 21:04
@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit jrafanie@7efe08f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@gildub
Copy link
Contributor

gildub commented Feb 21, 2018

@bdunne, please review.

@bdunne
Copy link
Member

bdunne commented Feb 21, 2018

@agrare Can you take a look at this one too?

agrare
agrare approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@agrare agrare merged commit b435114 into ManageIQ:master Feb 21, 2018
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 21, 2018
@agrare agrare self-assigned this Feb 21, 2018
@gildub
Copy link
Contributor

gildub commented Mar 7, 2018

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 8, 2018
@agrare @simaishi
Merge pull request #227 from jrafanie/rename_manageiq_network_to_netw…
532cafb 
…ork_discovery

Update client to use renamed NetworkDiscovery
(cherry picked from commit b435114)

https://bugzilla.redhat.com/show_bug.cgi?id=1552665
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 532cafb0c6e66556464cc38837f9c199d578af8d
Author: Adam Grare <[email protected]>
Date:   Wed Feb 21 09:44:12 2018 -0500

    Merge pull request #227 from jrafanie/rename_manageiq_network_to_network_discovery
    
    Update client to use renamed NetworkDiscovery
    (cherry picked from commit b43511485ba9e2ee40e655a6d2cc60f0957fcd95)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552665

@jrafanie jrafanie deleted the rename_manageiq_network_to_network_discovery branch January 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@bdunne bdunne bdunne approved these changes

Assignees

@agrare agrare

Labels
gaprindashvili/backported refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrafanie @gildub @miq-bot @bdunne @simaishi @agrare