Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send tenant with identity service requests #225

Merged

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Feb 8, 2018

@mansam
Copy link
Contributor Author

mansam commented Feb 8, 2018

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

Some comments on commits mansam/manageiq-providers-openstack@4fc9c90~...6b3f609

spec/vcr_cassettes/manageiq/providers/openstack/cloud_manager/refresher_rhos_icehouse_fast_refresh.yml

  • ⚠️ - 9172 - Detected pp. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

Checked commits mansam/manageiq-providers-openstack@4fc9c90~...6b3f609 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
25 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@aufi
Copy link
Member

aufi commented Feb 9, 2018

Tested and seems to be working fine for me 👍

@aufi aufi merged commit c1cbd5f into ManageIQ:master Feb 12, 2018
@aufi aufi added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 12, 2018
@aufi aufi added the bug label Feb 12, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

@mansam VCR conflict on backport... please advise what to do.

@mansam
Copy link
Contributor Author

mansam commented Mar 9, 2018

@simaishi I'll produce a new backport PR for you with updated VCRs for Gaprindashvili.

@simaishi
Copy link
Contributor

Backported to Gaprindashvili via #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants