Add proper error message if network type not supported #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
add-error-msg
branch
3 times, most recently
from
417bb99 to
149c02c
Compare
mansam
reviewed
Feb 2, 2018
| parsed_error = parse_error_message_from_neutron_response(e) | ||
| if parsed_error =~ /Invalid input for operation: network_type value '.*' not supported\./ | ||
| error_message = _("Network type '#{options[:provider_network_type]}' is not supported by the Provider") | ||
| raise MiqException::MiqNetworkCreateError, error_message, e.backtrace |
There was a problem hiding this comment.
Looks good! But you could do this without two "raises" by assigning back to parsed_error :)
There was a problem hiding this comment.
Thanks for review, does it look better now?
alexander-demicev
force-pushed
the
add-error-msg
branch
from
149c02c to
9710c9d
Compare
|
LGTM. Just the Rubocop warning - I wasn't used to assign the value that way but it makes sense. |
alexander-demicev
force-pushed
the
add-error-msg
branch
from
9710c9d to
a4deb4b
Compare
|
Checked commit alexander-demicev@a4deb4b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating network, add proper error message if network type is not supported by provider.
Fixes link