Fix disable CloudTenant Vm targeted refresh

[aufi]

Vm targeted refresh queued related Cloud Tenant refresh, that could fail due to
keystone v3 backend in fog or an issue in fog/openstack method get_project_by_id.

Queueing CloudTenant doesn't seem to be actually needed - disabled now and we should
make a cleanup in ongoing PR.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538741

[mansam]

@aufi thanks for the fix! also the targeted refresh vcr needs to be updated :)

[miq-bot]

Checked commit aufi@34de6c3 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

app/models/manageiq/providers/openstack/inventory/collector/target_collection.rb

• ❗ - Line 127, Col 112 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 257, Col 66 - Rails/Present - Use if tenant.try(:parent_id).present? instead of unless tenant.try(:parent_id).blank?.

[aufi]

@mansam Yes, thanks, based on @Ladas feedback, I trying find a way with performing custom get_project query, but didn't reach working auth (still getting 403 with https://gist.github.com/aufi/d014cc327081a709fcdef328b3444cb7). So decided to use list_projects and filter it in ruby, planning to fix it in more nice way updating fog with fog/fog-openstack#358

[aufi]

@mansam I've got error here without exclamation mark, so added it, is it ok?

[mansam]

@aufi yep!

[Ladas]

Looks good, we can't have a better fix now, since it;s broken inside fog-openstack

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit a071dd63fb167be49bc008d5a664442e71ee9217
Author: Ladislav Smola <[email protected]>
Date:   Mon Jan 29 19:12:59 2018 +0100

    Merge pull request #213 from aufi/fix_vm_targeted_refresh_tenant
    
    Fix disable CloudTenant Vm targeted refresh
    (cherry picked from commit e34789f7d6ee50a5768b6e9fa71f5ede1b98e394)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539874