Store selected user sync roles as custom attributes. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwsu
force-pushed
the
user-sync-custom-attributes
branch
from
0d412ff to
a4392d2
Compare
rwsu
changed the title
rwsu
force-pushed
the
user-sync-custom-attributes
branch
2 times, most recently
from
cf9d027 to
656904c
Compare
Selected roles are saved as provider custom attributes. If roles are changed between different syncs, user memberships from previously selected roles should be removed.
rwsu
force-pushed
the
user-sync-custom-attributes
branch
from
656904c to
74bb235
Compare
|
Checked commit rwsu@74bb235 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/openstack/identity_sync_mixin.rb
|
rwsu
changed the title
|
Looks good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected roles are saved as provider custom attributes.
If roles are changed between different syncs, user memberships from
previously selected roles should be removed.