Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing 'return' statement to 'network_manager.find_device_object' #188

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Add missing 'return' statement to 'network_manager.find_device_object' #188

merged 1 commit into from
Jan 8, 2018

Conversation

AlonaKaplan
Copy link
Contributor

@AlonaKaplan AlonaKaplan commented Jan 7, 2018 •
edited
Loading

@AlonaKaplan
Copy link
Contributor Author

AlonaKaplan commented Jan 7, 2018 •
edited
Loading

@Ladas please review

@miq-bot
Copy link
Member

miq-bot commented Jan 7, 2018

Checked commit AlonaKaplan@d9713f8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Ladas
Ladas approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a quick fix. (it should be refactored to have else branch and no returns probably)

@Ladas Ladas added the bug label Jan 8, 2018
@aufi aufi requested a review from mansam January 8, 2018 08:46
mansam
mansam approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mansam mansam merged commit 24814a4 into ManageIQ:master Jan 8, 2018
@AlonaKaplan
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Jan 9, 2018
@mansam @simaishi
Merge pull request #188 from AlonaKaplan/master
b13816c 
Add missing 'return' statement to 'network_manager.find_device_object'
(cherry picked from commit 24814a4)
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2018

Gaprindashvili backport details:

$ git log -1
commit b13816c271c4f1e2a83d0edb12894443b9d51743
Author: Samuel Lucidi <[email protected]>
Date:   Mon Jan 8 11:53:16 2018 -0500

    Merge pull request #188 from AlonaKaplan/master
    
    Add missing 'return' statement to 'network_manager.find_device_object'
    (cherry picked from commit 24814a41e49062b8944099d56ffde1a7e97d4ab6)

@aufi aufi added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

@mansam mansam mansam approved these changes

Assignees

@aufi aufi

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlonaKaplan @miq-bot @simaishi @mansam @Ladas @aufi