Skip disabled tenants when connecting to OpenStack #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to connect with disabled tenants generated misleading error messages, skipping disabled tenants when obtaining connection to OpenStack. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518625
|
Checked commit aufi@9591e89 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM! |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
Skip disabled tenants when connecting to OpenStack (cherry picked from commit e98c61d) https://bugzilla.redhat.com/show_bug.cgi?id=1520617
|
Gaprindashvili backport details: |
|
@blomquisg @simaishi Backport should not be problem (except the severity of BZ which was only about error records in log, but that's not a technical obstackle). I checked Euwe branch and dependencies of this change are already there, so it should be easy to backport. Is it possible make it "automatically" or should backport PRs be created by me? |
|
Fine backport (to manageiq-gems-pending repo) details: |
|
Euwe backport (to manageiq repo) details: |
|
@aufi Backported to Fine and Euwe without problem, so this is all set! |
|
@simaishi Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to connect with disabled tenants generated misleading error messages,
skipping disabled tenants when obtaining connection to OpenStack.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518625