add error message if FIP assigned to router #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After more detailed reading of the BZ, it looks we should lookup instances with Floating IP connected via the Router [1]. Router.floating_ips method returns list of floating_ip on the connected network, we propably could filter just FIPs which are associated with a VM on such network. @alexander-demichev please include steps how this should be tested (positive and negative example), thanks! |
alexander-demicev
force-pushed
the
unsupported-router-delete
branch
from
aa2715b to
0879469
Compare
alexander-demicev
force-pushed
the
unsupported-router-delete
branch
from
0879469 to
fe16fb8
Compare
|
Checked commit alexander-demicev@fe16fb8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good to me, merging! |
|
BZ doesn't specify G-release as target release, feel free update it if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router can't be deleted if has assigned floating ips.
https://bugzilla.redhat.com/show_bug.cgi?id=1470754