Restore missing quotas in new graph-based collector #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quotas were missing because ems_ref was being set to the tenant_id which is not unique. Changed ems_ref to [tenant_id, quota name] to match what was being used as lookup value to find_or_build. Also removed collection of quotas that we are not modeling: metadata items, injected files, server groups, and rbac policies. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1512641
|
Checked commit rwsu@235669e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 20, 2017
Restore missing quotas in new graph-based collector (cherry picked from commit 8cbf103) https://bugzilla.redhat.com/show_bug.cgi?id=1515488
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotas were missing because ems_ref was being set to the tenant_id
which is not unique. Changed ems_ref to [tenant_id, quota name] to
match what was being used as lookup value to find_or_build.
Also removed collection of quotas that we are not modeling:
metadata items, injected files, server groups, and rbac policies.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1512641