Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ 1396218: don't attempt cloning of OpenStack infra templates #153

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

sseago
Copy link
Contributor

@sseago sseago commented Nov 13, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1396218

OpenStack infra template cloning is not supported. With this fix
a flash message tells the user this is unsupported rather than
trying (and failing) to render the clone form.

https://bugzilla.redhat.com/show_bug.cgi?id=1396218

OpenStack infra template cloning is not supported. With this fix
a flash message tells the user this is unsupported rather than
trying (and failing) to render the clone form.
@miq-bot
Copy link
Member

miq-bot commented Nov 13, 2017

Checked commit sseago@fde2e77 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@mansam
Copy link
Contributor

mansam commented Nov 13, 2017

LGTM

@mansam mansam merged commit c263266 into ManageIQ:master Nov 13, 2017
@aufi aufi added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 14, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
BZ 1396218: don't attempt cloning of OpenStack infra templates
(cherry picked from commit c263266)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d70e8f035c3b39840124743e7a9bab9376b60f02
Author: Samuel Lucidi <[email protected]>
Date:   Mon Nov 13 16:52:19 2017 -0500

    Merge pull request #153 from sseago/bz1396218
    
    BZ 1396218: don't attempt cloning of OpenStack infra templates
    (cherry picked from commit c263266b5b9f9ba37040858b8ff4df45b4defe60)

@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit e7dd4708d9e7bc3a12f1856eb42db119fcd8671f
Author: Samuel Lucidi <[email protected]>
Date:   Mon Nov 13 16:52:19 2017 -0500

    Merge pull request #153 from sseago/bz1396218
    
    BZ 1396218: don't attempt cloning of OpenStack infra templates
    (cherry picked from commit c263266b5b9f9ba37040858b8ff4df45b4defe60)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants