Make sure volume template has name #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure volume template has name Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1510067
|
@mansam I haven't checked the old refresh, we might need same fix there |
|
Checked commit Ladas@d5f0a00 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
approved these changes
Nov 9, 2017
|
I don't see volume_template parsing for non-graph refresh, @mansam is this expected or was it an oversight? |
|
@agrare That's deliberately only being supported on the graph refresh system. |
|
Thanks @mansam 👍 to this then |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
…ave_blank_name Make sure volume template has name (cherry picked from commit 5a99b6f) https://bugzilla.redhat.com/show_bug.cgi?id=1511083
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure volume template has name
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1510067