Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for amqp events #131

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Fix for amqp events #131

merged 2 commits into from
Oct 25, 2017

Conversation

tzumainn
Copy link
Contributor

Handles the case where the amqp message doesn't have the oslo.message key

https://bugzilla.redhat.com/show_bug.cgi?id=1451437

@mansam
Copy link
Contributor

mansam commented Oct 25, 2017 •
edited
Loading

LGTM, but would you fix the parentheses thing? :)

@tzumainn
Copy link
Contributor Author

Oh yeah! Fixed now - thanks!

@miq-bot
Copy link
Member

miq-bot commented Oct 25, 2017

Checked commits tzumainn/manageiq-providers-openstack@0f3122d~...c842c6c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@mansam mansam merged commit 438728f into ManageIQ:master Oct 25, 2017
@aufi aufi added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 51599d545d8023ff34aeec57aa2bc54c71478ac9
Author: Samuel Lucidi <[email protected]>
Date:   Wed Oct 25 16:19:40 2017 -0400

    Merge pull request #131 from tzumainn/amqp-event-fix
    
    Fix for amqp events
    (cherry picked from commit 438728f8bc924ca1b3254b5ea5038fa8b11df3ac)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1506626

@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit 6d07c6f034f3f538968eb3232253f13835232217
Author: Samuel Lucidi <[email protected]>
Date:   Wed Oct 25 16:19:40 2017 -0400

    Merge pull request #131 from tzumainn/amqp-event-fix
    
    Fix for amqp events
    (cherry picked from commit 438728f8bc924ca1b3254b5ea5038fa8b11df3ac)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1506624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tzumainn @mansam @miq-bot @simaishi @aufi