Filter out resources with blank physical_resource_id #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
force-pushed
the
filter_out_resources_without_physical_resource_id
branch
from
8fe9503 to
4b18799
Compare
mansam
reviewed
Oct 11, 2017
| @@ -173,6 +173,8 @@ def orchestration_stack_resources(stack, stack_inventory_object) | |||
| raw_resources.reject! { |r| r.physical_resource_id.nil? } | |||
There was a problem hiding this comment.
There's already a check on this line for nil, just like in the old refresher. I'm guessing it should be changed to a check for blank?
There was a problem hiding this comment.
hum, you might be right
There was a problem hiding this comment.
yeah, the build method checks blank? https://github.com/Ladas/manageiq/blob/17c884ab58ea6e7f0aad11dd87982adf24409c17/app/models/manager_refresh/inventory_collection.rb#L754
Ladas
force-pushed
the
filter_out_resources_without_physical_resource_id
branch
2 times, most recently
from
26b632b to
258732c
Compare
Filter out resources with no physical_resource_id. Before we were ignoring those with: https://github.com/Ladas/manageiq-providers-openstack/blob/d0799c4a5766650f2d3d149875c1b58f8a16040f/app/models/manageiq/providers/openstack/refresh_parser_common/orchestration_stacks.rb#L165 Without ignoring thise results in error : [NoMethodError]: undefined method `ems_ref=' for nil:NilClass Method:[block in method_missing]
Ladas
changed the title
Ladas
force-pushed
the
filter_out_resources_without_physical_resource_id
branch
from
258732c to
b89f7ab
Compare
|
Checked commit Ladas@b89f7ab with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
💯 🚀 LGTM |
mansam
approved these changes
Oct 11, 2017
|
This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1500314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out resources with blank physical_resource_id.
Before we were ignoring those with:
https://github.com/Ladas/manageiq-providers-openstack/blob/d0799c4a5766650f2d3d149875c1b58f8a16040f/app/models/manageiq/providers/openstack/refresh_parser_common/orchestration_stacks.rb#L165
Without ignoring thise results in error :
[NoMethodError]: undefined method `ems_ref=' for nil:NilClass Method:[block in method_missing]