mapping.tag is a category Tag, calling .category is ill-defined #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently .category on a category Tag ("/managed/cat") happens to
work same as .classification, but it's ill-defined and will
stop working after ManageIQ/manageiq#17418.
.parent
category Classification "cat" <---------- entry Classification "ent"
|^ ^ |^
.tag||.classification \_______________ .tag||.classification
v| .category \ v|
category Tag /managed/cat entry Tag /managed/cat/ent
cben
changed the title
.parent category Classification "cat" <---------- entry Classification "ent" |^ ^ |^ .tag||.classification \_______________ .tag||.classification v| .category \ v| category Tag /managed/cat entry Tag /managed/cat/ent .category is supposed to get the "uncle", the category Classification from an *entry* Tag.
|
Checked commit cben@ecf8b31 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are category/entry Tags, and category/entry Classifications.
.categoryis supposed to get the "uncle", the category Classification from an entry Tag.mapping.tagis a category Tag (for any-value mappings which are the kind we use).Currently
.categoryon a category Tag ("/managed/cat") happens to work same as.classification, but it's ill-defined and will stop working after ManageIQ/manageiq#17418.@miq-bot add-label test, technical debt
@kbrock @Fryguy please review