-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAPRINDASHVILI] [CHANGELOG] Update for Gaprindashvili-1 #80
Conversation
@miq-bot add_label documentation |
Checked commit JPrause@8fc291a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot remove_label wip |
### Fixed | ||
- Fix Inventory Collector has_required_role? [(#65)](https://github.com/ManageIQ/manageiq-providers-openshift/pull/65) | ||
|
||
## Gaprindashvili Beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these were public betas, IMHO it adds values to keep the granularity what changed in each of them?
BTW, can you specify date or version for "Initial changelog added" at bottom? Otherwise, the whole section for changes in "Gaprindashvili-1" is not very useful because unclear since when...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is process we follow for all repos and releases.
Once we do a release, we roll up all betas and rcs into a final release.
I'll add the "Initial Changelog added" on the next changelog submission. I do have that in other repos and it seems overlooked this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[skip ci]