Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] [CHANGELOG] Update for Gaprindashvili-1 #80

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

JPrause
Copy link
Member

@JPrause JPrause commented Jan 9, 2018

[skip ci]

@JPrause
Copy link
Member Author

JPrause commented Jan 9, 2018

@miq-bot add_label documentation

@miq-bot miq-bot changed the title [WIP][CHANGELOG] Update for Gaprindashvili-1 [GAPRINDASHVILI] [WIP][CHANGELOG] Update for Gaprindashvili-1 Jan 9, 2018
@miq-bot miq-bot added the wip label Jan 9, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2018

Checked commit JPrause@8fc291a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@JPrause JPrause changed the title [GAPRINDASHVILI] [WIP][CHANGELOG] Update for Gaprindashvili-1 [GAPRINDASHVILI] [CHANGELOG] Update for Gaprindashvili-1 Jan 18, 2018
@JPrause
Copy link
Member Author

JPrause commented Jan 18, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Jan 18, 2018
### Fixed
- Fix Inventory Collector has_required_role? [(#65)](https://github.com/ManageIQ/manageiq-providers-openshift/pull/65)

## Gaprindashvili Beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these were public betas, IMHO it adds values to keep the granularity what changed in each of them?

BTW, can you specify date or version for "Initial changelog added" at bottom? Otherwise, the whole section for changes in "Gaprindashvili-1" is not very useful because unclear since when...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is process we follow for all repos and releases.
Once we do a release, we roll up all betas and rcs into a final release.
I'll add the "Initial Changelog added" on the next changelog submission. I do have that in other repos and it seems overlooked this one.

@cben cben requested a review from moolitayer January 20, 2018 19:56
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moolitayer moolitayer merged commit 7b7dfea into ManageIQ:gaprindashvili Jan 21, 2018
@moolitayer moolitayer added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants