Add openshift persister and test also batch saver strategy #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cben
reviewed
Jul 27, 2017
| super | ||
| # get_container_images=false mode is a stopgap to speed up refresh by reducing functionality. When it's flipped from true to false, we should at least retain existing metadata. | ||
| if options.get_container_images | ||
| initialize_custom_attributes_collections(ems.container_images, %w(labels docker_labels)) |
There was a problem hiding this comment.
this is still needed, unless I missed it somewhere else
There was a problem hiding this comment.
it is inside of the OpenShift persistor
|
This pull request is not mergeable. Please rebase and repush. |
24 tasks
|
LGTM 👍 |
Add OpenShift Persister
Redefine persister_class to OpenShift one
Test :batch and :default saving strategies
Ladas
force-pushed
the
add_openshift_persister_and_test_also_batch_saver_strategy
branch
from
0eb4a5e to
8c0d19b
Compare
Ladas
changed the title
Better comment anout skipping ContainerImages labels saving
|
@cben it should be ready now |
|
Checked commits Ladas/manageiq-providers-openshift@0b85322~...3f27d49 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Add openshift persister and test also batch saver strategy