Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerImage archivation #101

Merged
merged 1 commit into from
Jul 4, 2018
Merged

ContainerImage archivation #101

merged 1 commit into from
Jul 4, 2018

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jul 3, 2018 •
edited by agrare
Loading

ContainerImage is not destroyed by ContainerImageRegistry, which fixes pending specs

Cc @cben, @Ladas

@slemrmartin
Pending refresh spec solution
6e0129d 
ContainerImage is not destroyed by ContainerImageRegistry
@slemrmartin slemrmartin mentioned this pull request Jul 3, 2018
Merged
1 task
@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2018

Checked commit slemrmartin@6e0129d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

cben
cben approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! pending core PR.

Ladas
Ladas approved these changes Jul 4, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare self-assigned this Jul 4, 2018
@agrare agrare closed this Jul 4, 2018
@agrare agrare reopened this Jul 4, 2018
@cben cben closed this Jul 4, 2018
@cben cben reopened this Jul 4, 2018
@cben cben added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 4, 2018
@cben cben merged commit bb1fb97 into ManageIQ:master Jul 4, 2018
@slemrmartin slemrmartin deleted the container-image-deleting branch July 11, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

@cben cben cben approved these changes

Assignees

@agrare agrare

Labels
inventory test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slemrmartin @miq-bot @cben @Ladas @agrare