Connect events to targeted refresh #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will fail until EventCatcher isn't merged but I'd kindly ask you @Ladas to take a look at it anyway (it's a very short PR). |
miha-plesko
force-pushed
the
connect-events-to-targeted-refresh
branch
from
585846b to
72e3bff
Compare
miha-plesko
changed the title
With this commit we teach our NetworkManager how to map obtained events to appropriate target. At the moment only events concerning the three supported targets actually trigger something: ``` - network_groups - cloud_subnets - security_groups ``` while all other events are simply skipped. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
connect-events-to-targeted-refresh
branch
from
72e3bff to
8f42f32
Compare
|
Some comments on commit miha-plesko@8f42f32 spec/models/manageiq/providers/nuage/network_manager/event_target_parser_spec.rb
|
|
Checked commit miha-plesko@8f42f32 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we teach our NetworkManager how to map obtained events to appropriate targets. At the moment only events concerning the three supported targets actually trigger something:
while all other events are simply skipped.
Depends on: #9
@miq-bot add_label enhancement
@miq-bot assign @Ladas
/cc @gberginc