Removed unnecessary https protocol from hostname URI #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucashsilva
force-pushed
the
remove_https
branch
from
fe2476e to
b93bc78
Compare
|
Checked commit lucashsilva@b93bc78 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
walteraa
approved these changes
Oct 31, 2017
| @@ -98,7 +98,7 @@ def discover(ip_address, port) | |||
| if XClarityClient::Discover.responds?(ip_address, port) | |||
| new_ems = create!( | |||
| :name => "Discovered Provider ##{count + 1}", | |||
| :hostname => URI('https://' + ip_address), | |||
| :hostname => URI(ip_address), | |||
|
@miq-bot assign @juliancheal |
AndreyMenezes
requested review from
juliancheal,
AndreyMenezes and
agrare
and removed request for
agrare and
juliancheal
lucashsilva
changed the title
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Removed unecessary https protocol from hostname URI (cherry picked from commit 5504ff3)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes unecessary https protocol (prefix) from hostname URI in discover method sice it's no longer needed.