Test the end-to-end refresh in the refresher_spec #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
test_full_refresh
branch
from
2052df3 to
58451d9
Compare
|
Hm this is passing locally, not sure why failing on travis |
rodneyhbrown7
approved these changes
Oct 20, 2017
|
@agrare Can you close and reopen this PR to see if it will pass travis tests? |
Instead of just testing parse with vcr, then saving no inventory we can run the full EmsRefresh.refresh in the vcr block so we can test relationship links created in save_ems_inventory in the future.
agrare
force-pushed
the
test_full_refresh
branch
from
58451d9 to
6efc540
Compare
|
Checked commit agrare@6efc540 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/manageiq/providers/lenovo/physical_infra_manager/refresher_spec.rb
|
|
Same problem, wondering if there are some difference between how the parser was invoked by the original test vs a full refresh. |
|
This pull request is not mergeable. Please rebase and repush. |
|
Closing now that #138 does a full refresh test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just testing parse with vcr, then saving no inventory we can
run the full EmsRefresh.refresh in the vcr block so we can test
relationship links created in save_ems_inventory in the future.