Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run provider generator to sync changes from core #63

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

durandom
Copy link
Member

ran the generator again with

bundle exec rails g provider <name> --path ../

these are the changes.

@durandom durandom force-pushed the provider_generator branch from b7d9653 to 9380548 Compare July 19, 2017 15:17
@miq-bot
Copy link
Member

miq-bot commented Jul 19, 2017

Checked commit durandom@9380548 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 7 offenses detected

lib/manageiq-providers-lenovo.rb

  • ❗ - Line 1, Col 1 - Style/FileName - The name of this source file (manageiq-providers-lenovo.rb) should use snake_case.

lib/tasks/lenovo.rake

lib/tasks_private/spec.rake

:host:
:password:
:port:
:user:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any settings that have to come over from ManageIQ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes there are some, but should be part of a different PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #65

@Fryguy Fryguy merged commit d10e68d into ManageIQ:master Jul 20, 2017
@Fryguy Fryguy added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 20, 2017
@Fryguy Fryguy added the cleanup label Jul 20, 2017
@Fryguy Fryguy self-assigned this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants