Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source name and add physical_server_id #38

Merged
merged 2 commits into from
Apr 4, 2017

Conversation

AndreyMenezes
Copy link
Member

This PR do the follow changes:

  • Change the source name of the Lenovo's provider.
  • Add the physical server identify into event hash.

This PR depends on a migration in Event Stream to add physical_server_id

@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2017

Checked commits AndreyMenezes/manageiq-providers-lenovo@54daaf4~...bc5fc93 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 9 offenses detected

app/models/manageiq/providers/lenovo/physical_infra_manager/event_parser.rb

  • ❗ - Line 10, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 11, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 12, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 4, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 5, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 6, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 7, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 8, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
  • ❗ - Line 9, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@blomquisg blomquisg merged commit 77d9da2 into ManageIQ:master Apr 4, 2017
@blomquisg blomquisg added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 4, 2017
@juliancheal
Copy link
Member

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Apr 11, 2017
Change source name and add physical_server_id
(cherry picked from commit 77d9da2)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 0b6f48c3f7cf4997b92808e256f9f01bcd19c289
Author: Greg Blomquist <[email protected]>
Date:   Tue Apr 4 10:26:20 2017 -0400

    Merge pull request #38 from AndreyMenezes/change_source_name
    
    Change source name and add physical_server_id
    (cherry picked from commit 77d9da2945899a171419dd2470255db03bda8a7a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants