-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring of refresh #34
Conversation
Added Firmware model Started to extract attributes to add to other tables such as: hardwares, networks, etc.
For the Lenovo team, this preps our refresher for broader support of the hardware model. I don't think this significantly changes how we populate the attributes of the physical_server. |
Think I get what you're saying. It's mainly the |
Pares out data from Firmware, but doesn't save it yet… We need to hang Firmwares off of Guest Device…
Removed networks for now as we need more data as to where the Mac Address, and IP information comes from and how they relate.
Checked commits e89c75c~...ff96e5b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/lenovo/physical_infra_manager/refresh_parser.rb
|
@miq-bot remove_label wip |
@blomquisg this is ready to merge (nb. lack of tests that will come in a follow up PR). |
@miq-bot add_label fine/yes |
refactoring of refresh (cherry picked from commit e92dc1f)
Fine backport details:
|
Added Firmware model
Started to extract attributes to add to other tables such as:
hardwares, networks, etc.