Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of refresh #34

Merged
merged 4 commits into from
Apr 4, 2017
Merged

refactoring of refresh #34

merged 4 commits into from
Apr 4, 2017

Conversation

juliancheal
Copy link
Member

Added Firmware model

Started to extract attributes to add to other tables such as:
hardwares, networks, etc.

Added Firmware model

Started to extract attributes to add to other tables such as:
hardwares, networks, etc.
@rodneyhbrown7
Copy link
Contributor

For the Lenovo team, this preps our refresher for broader support of the hardware model. I don't think this significantly changes how we populate the attributes of the physical_server.

@juliancheal
Copy link
Member Author

For the Lenovo team, this preps our refresher for broader support of the hardware model. I don't think this significantly changes how we populate the attributes of the physical_server.

Think I get what you're saying. It's mainly the mac address & ip addresses that I'm extracting out to store in Networks via Hardwares.

Julian Cheal added 2 commits March 17, 2017 19:57
Pares out data from Firmware, but doesn't save it yet…

We need to hang Firmwares off of Guest Device…
Removed networks for now as we need more data as to where the
Mac Address, and IP information comes from and how they relate.
@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2017

Checked commits e89c75c~...ff96e5b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

app/models/manageiq/providers/lenovo/physical_infra_manager/refresh_parser.rb

  • ❗ - Line 80, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@juliancheal
Copy link
Member Author

@miq-bot remove_label wip

@juliancheal juliancheal changed the title [WIP] refactoring of refresh refactoring of refresh Mar 24, 2017
@miq-bot miq-bot removed the wip label Mar 24, 2017
@juliancheal
Copy link
Member Author

@blomquisg this is ready to merge (nb. lack of tests that will come in a follow up PR).

@blomquisg blomquisg merged commit e92dc1f into ManageIQ:master Apr 4, 2017
@blomquisg blomquisg added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 4, 2017
@juliancheal
Copy link
Member Author

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Apr 11, 2017
refactoring of refresh
(cherry picked from commit e92dc1f)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 08331b54b5fa81f2d0f77704986c06cc5c6a2517
Author: Greg Blomquist <[email protected]>
Date:   Tue Apr 4 12:58:07 2017 -0400

    Merge pull request #34 from juliancheal/refactor_refresh
    
    refactoring of refresh
    (cherry picked from commit e92dc1f7e335cca6fd8968aa2f9bcca2c5f0017d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants