Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/settings - add missing fields, fixing ui-classic breakage #218

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Aug 9, 2018

Every event group in settings needs to have 3 arrays: critical, detail, warning.

#217 introduces a couple of groups missing one or two of the required arrays, which breaks 54 ui-classic specs :): https://gist.github.com/himdel/c7b682676542936c8e4533ee58da7ebb (example https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/413927437)

Adding the missing ones here.

Cc: @matheuscmelo, @CharlleDaniel , @agrare

every event group in settings needs to have 3 arrays: critical, detail, warning

ManageIQ/managieq-providers-lenovo#217 introduces a couple of groups missing one or two of the required arrays, adding the missing ones here.
@juliancheal juliancheal self-assigned this Aug 9, 2018
@juliancheal juliancheal added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 9, 2018
@juliancheal juliancheal merged commit 5a0b6c2 into ManageIQ:master Aug 9, 2018
@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2018

Checked commit https://github.com/himdel/manageiq-providers-lenovo/commit/e9ded3e979076f1a5e2c3ebccac6cbb9b4729a0b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel himdel deleted the fix-217 branch August 9, 2018 12:09
@himdel
Copy link
Contributor Author

himdel commented Aug 9, 2018

@miq-bot add_label bug, gaprindashvili/no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants