Parsing physical_swtich_id and physical_chassis_id into events #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipedf
force-pushed
the
physical_switch_into_events
branch
9 times, most recently
from
f56983a to
3049045
Compare
felipedf
changed the title
felipedf
force-pushed
the
physical_switch_into_events
branch
from
3049045 to
7fdf7c2
Compare
| elsif SERVER.include?(event[:component_type]) | ||
| event_resources[:physical_server_id] = get_klass_id(PhysicalServer, event[:component_id]) | ||
| else | ||
| raise(NotImplementedError, "The event of type #{event[:component_type]} is not supported") |
There was a problem hiding this comment.
I think that is a little better only create a new log output like $log.error(message) instead of raise an exception. @felipedf and @douglasgabriel do you agree ?
douglasgabriel
suggested changes
Jul 24, 2018
| @@ -32,7 +36,29 @@ def self.filter_data(data) | |||
| } | |||
| end | |||
|
|
|||
| def self.get_physical_server_id(ems_ref) | |||
| PhysicalServer.find_by(:ems_ref => ems_ref).try(:id) | |||
| class << self | |||
There was a problem hiding this comment.
Request
To keep the consistency, you can wrap all class definitions with class << self
| elsif SERVER.include?(event[:component_type]) | ||
| event_resources[:physical_server_id] = get_klass_id(PhysicalServer, event[:component_id]) | ||
| else | ||
| raise(NotImplementedError, "The event of type #{event[:component_type]} is not supported") |
| event_resources | ||
| end | ||
|
|
||
| def get_klass_id(klass, uid_ems) |
There was a problem hiding this comment.
Suggestion
In this method you are getting the id of the event resource, so I would say that the name get_resource_id fit better the goal of the method, don't you think?
felipedf
force-pushed
the
physical_switch_into_events
branch
2 times, most recently
from
3936017 to
9d12630
Compare
|
Checked commit felipedf@9d12630 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
douglasgabriel
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to parse
physical_switch_idinto events, so we can handle events for switches.Depends on: ManageIQ/manageiq-schema#229