Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the event catcher bug #199

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

CharlleDaniel
Copy link
Member

This pr is able to:

  • Fix the event catcher break when there is no more events to be parsed.

@CharlleDaniel
Copy link
Member Author

@miq-bot add_reviewer @agrare

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

@CharlleDaniel unrecognized command 'assing', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot miq-bot requested a review from agrare June 12, 2018 17:09
@CharlleDaniel
Copy link
Member Author

@miq-bot assign @agrare

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

Checked commit CharlleDaniel@2a3d816 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch @CharlleDaniel

@agrare agrare merged commit 2a3d816 into ManageIQ:master Jun 12, 2018
agrare added a commit that referenced this pull request Jun 12, 2018
@agrare agrare added the bug label Jun 12, 2018
@agrare agrare added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants