Fix bug when portInfo was null #168
Conversation
|
@miq-bot add_label bug |
|
@miq-bot assign @agrare |
| @@ -90,7 +90,7 @@ def parse_child_devices(device, all_devices) | |||
|
|
|||
| def parse_ports(port) | |||
| port_info = port["portInfo"] | |||
| physical_ports = port_info["physicalPorts"] | |||
| physical_ports = port_info&.try(:[], 'physicalPorts') | |||
There was a problem hiding this comment.
I believe that a try call here is enough, you can remove the &.
There was a problem hiding this comment.
That's correct, or you can use port_info&.dig('physicalPorts')...up to you but I've never liked the way .try looks with a hash dereference
There was a problem hiding this comment.
Cool, .dig seems cleaner to me
| @@ -90,7 +90,7 @@ def parse_child_devices(device, all_devices) | |||
|
|
|||
| def parse_ports(port) | |||
| port_info = port["portInfo"] | |||
| physical_ports = port_info["physicalPorts"] | |||
| physical_ports = port_info&.try(:[], 'physicalPorts') | |||
| physical_ports&.map do |physical_port| | |||
There was a problem hiding this comment.
To keep the pattern, could you replace the & with a try call?
|
This pull request is not mergeable. Please rebase and repush. |
|
@felipedf looks good but can you rebase on master and resolve the conflict? |
|
Checked commit felipedf@35fda32 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
The refresh was crashing when a port didn't contain a "portInfo" field