Moving strings to dictionary and cleaning up empty and malformatted strings #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
saulotoledo
force-pushed
the
parser_strings_cleanup
branch
from
11099af to
13aa383
Compare
saulotoledo
changed the title
saulotoledo
changed the title
saulotoledo
force-pushed
the
parser_strings_cleanup
branch
from
13aa383 to
8c8f1fa
Compare
saulotoledo
force-pushed
the
parser_strings_cleanup
branch
from
8c8f1fa to
2c5ddad
Compare
|
Checked commit saulotoledo@2c5ddad with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
saulotoledo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #132 and should be merged later. It moves some strings to the dictionary in several parsers and automatically removes trailing whitespaces and convert empty strings to
nil. By doing that, the data is normalized in the database and through API access.Depends on: