Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing partNumber for Physical Servers #156

Conversation

saulotoledo
Copy link
Member

@saulotoledo saulotoledo commented Apr 16, 2018

This PR adds the part_number value for Physical Servers.

Depends on:

@rodneyhbrown7
Copy link
Contributor

@saulotoledo I expect travis to pass now that the schema changes have been merged. I tested this locally and I have no issues. This should be mergeable.

@saulotoledo saulotoledo force-pushed the adding_part_number_to_physical_servers branch from 2b9dd0e to 5252257 Compare April 18, 2018 10:30
@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2018

Checked commit saulotoledo@5252257 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@rodneyhbrown7 rodneyhbrown7 merged commit a1a013e into ManageIQ:master Apr 18, 2018
@agrare agrare added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants