Parsing pci_device and vlan info to ports #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ManageIQ/manageiq-schema#165 was merged |
|
@felipedf it looks like you amended a merge commit or something, can you fix that up? |
felipedf
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
|
@felipedf please fix the commit and assign back to me when it is ready for review |
|
#132 is parsing those into physical switch's ports, here were trying to parse them for a physical server |
felipedf
force-pushed
the
add_vlan_info
branch
2 times, most recently
from
b3538dd to
bd45a96
Compare
|
Checked commit felipedf@bd45a96 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
felipedf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some vlan info to ports (guest_devices) and parse pciDevices of a Node
Did some refactor on AddinCards to use the same method to parse PciDevices as well, because they have the same fields.
Basically I am parsing the new info added to the schema on ManageIQ/manageiq-schema#165
:vlan_enabled => port["vnicMode"],
:vlan_key => port["logicalPortIndex"],
Depends on: ManageIQ/manageiq-schema#165