Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving the disk capacity blank if the LXCA doesn't provide this information #141

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

douglasgabriel
Copy link
Member

@douglasgabriel douglasgabriel commented Mar 16, 2018

Actual Result:
When the LXCA doesn't provide this information, the disk capacity is set to 0, what could provide a wrong impression to use.
disk-capacity
Expected Result:
Leave this field blank to represent the lack of information.
image

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1560074

@douglasgabriel
Copy link
Member Author

@miq-bot assign @agrare

@douglasgabriel
Copy link
Member Author

@miq-bot add_label enhancement, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2018

Checked commit douglasgabriel@55c4830 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare merged commit df476a0 into ManageIQ:master Mar 21, 2018
@agrare agrare added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 21, 2018
@simaishi
Copy link
Contributor

@douglasgabriel Please add BZ link.

@douglasgabriel
Copy link
Member Author

@simaishi
Copy link
Contributor

@douglasgabriel It looks like def get_disk_capacity was added in #122, which is not in gaprindashvili. Guess this isn't needed in G-branch?

@douglasgabriel
Copy link
Member Author

You're right @simaishi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants