-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the parse structure #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasgabriel
force-pushed
the
rft_parse_structure
branch
from
March 13, 2018 12:08
be1a3a5
to
c8d98ab
Compare
douglasgabriel
force-pushed
the
rft_parse_structure
branch
2 times, most recently
from
March 13, 2018 12:24
94a2de5
to
0f1eb2f
Compare
This pull request is not mergeable. Please rebase and repush. |
Looks like some good refactoring, 👍 just needs a rebase |
douglasgabriel
force-pushed
the
rft_parse_structure
branch
7 times, most recently
from
March 15, 2018 14:38
335c2cd
to
9699a28
Compare
douglasgabriel
force-pushed
the
rft_parse_structure
branch
from
March 15, 2018 14:39
9699a28
to
7ef9f06
Compare
Checked commit douglasgabriel@7ef9f06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Done @agrare 👍 |
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 16, 2018
Refactoring the parse structure
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 16, 2018
Refactoring the parse structure
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 16, 2018
Refactoring the parse structure
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 16, 2018
Refactoring the parse structure
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 16, 2018
Refactoring the parse structure
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 27, 2018
Refactoring the parse structure
felipedf
pushed a commit
to felipedf/manageiq-providers-lenovo
that referenced
this pull request
Mar 29, 2018
Refactoring the parse structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to:
Parsers
module to namespace the new parsers structure;parser.rb
, transforming it in a service class to provide the parsers methods.Main goals:
parser.rb
due to adding of new LXCA components;