Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the parse structure #139

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

douglasgabriel
Copy link
Member

@douglasgabriel douglasgabriel commented Mar 13, 2018

This PR is able to:

  • Create specialized classes to parse LXCA components;
  • Create the Parsers module to namespace the new parsers structure;
  • Remove components parser code from parser.rb, transforming it in a service class to provide the parsers methods.

Main goals:

  • Avoid the rapid growth of the parser.rb due to adding of new LXCA components;
  • Improve the maintainability of the Parsers structure.

@douglasgabriel
Copy link
Member Author

@miq-bot assign @agrare

@douglasgabriel douglasgabriel force-pushed the rft_parse_structure branch 2 times, most recently from 94a2de5 to 0f1eb2f Compare March 13, 2018 12:24
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2018

This pull request is not mergeable. Please rebase and repush.

@agrare
Copy link
Member

agrare commented Mar 15, 2018

Looks like some good refactoring, 👍 just needs a rebase

@douglasgabriel douglasgabriel force-pushed the rft_parse_structure branch 7 times, most recently from 335c2cd to 9699a28 Compare March 15, 2018 14:38
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2018

Checked commit douglasgabriel@7ef9f06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. 👍

@douglasgabriel
Copy link
Member Author

Done @agrare 👍

@agrare agrare merged commit d5f3d3e into ManageIQ:master Mar 16, 2018
@agrare agrare added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 16, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 16, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 16, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 16, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 16, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 16, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 27, 2018
felipedf pushed a commit to felipedf/manageiq-providers-lenovo that referenced this pull request Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants