Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parse physical rack #127

Closed
wants to merge 0 commits into from

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Jan 22, 2018

Parse info from a PhysicalRack and PhysicalServer now is parsed through PhysicalRack

@felipedf felipedf changed the title Parse physical rack [WIP] Parse physical rack Jan 25, 2018
@miq-bot miq-bot added the wip label Jan 25, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the parse_physical_rack branch from 4ffabac to 4fd4096 Compare January 25, 2018 16:59
@felipedf felipedf force-pushed the parse_physical_rack branch from 4fd4096 to b9c7159 Compare January 25, 2018 17:07
@felipedf felipedf changed the title [WIP] Parse physical rack Parse physical rack Jan 25, 2018
@miq-bot miq-bot removed the wip label Jan 25, 2018
@felipedf felipedf force-pushed the parse_physical_rack branch 3 times, most recently from 40c5024 to dc26ab2 Compare February 1, 2018 13:57
@felipedf felipedf force-pushed the parse_physical_rack branch from dc26ab2 to b93d74a Compare February 8, 2018 19:18
@felipedf felipedf force-pushed the parse_physical_rack branch from b93d74a to db17f20 Compare February 21, 2018 13:41
@felipedf felipedf changed the title Parse physical rack [WIP] Parse physical rack Feb 21, 2018
@miq-bot miq-bot added the wip label Feb 21, 2018
@felipedf felipedf force-pushed the parse_physical_rack branch from db17f20 to 7a145d5 Compare February 21, 2018 20:51
@felipedf felipedf closed this Feb 22, 2018
@felipedf felipedf reopened this Feb 22, 2018
@felipedf felipedf force-pushed the parse_physical_rack branch from 7a145d5 to 988dad5 Compare February 22, 2018 13:34
@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the parse_physical_rack branch 5 times, most recently from e1aa65a to b4af5df Compare March 16, 2018 19:15
@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2018

Checked commit felipedf@b4af5df with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2018

This pull request is not mergeable. Please rebase and repush.

@agrare
Copy link
Member

agrare commented Mar 29, 2018

@felipedf still looks like you've amended a merge commit, can you git reset upstream/master, then git commit -a

@felipedf felipedf closed this Mar 29, 2018
@felipedf felipedf force-pushed the parse_physical_rack branch from b4af5df to 4367fbf Compare March 29, 2018 19:21
@felipedf
Copy link
Member Author

@agrare I messed up really hard with this branch 😭 😭 , I am opening another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants