Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing tests for the new hostname validation #123

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Fixing tests for the new hostname validation #123

merged 1 commit into from
Jan 15, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Jan 11, 2018 •
edited
Loading

Fix failing travis tests for the new hostname validation that came after ManageIQ/manageiq#16714

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2018

Checked commit felipedf@70e98b9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

@felipedf
Copy link
Member Author

@agrare can you take a look at this one?

agrare
agrare approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM thanks @felipedf !

@agrare agrare merged commit f7509d2 into ManageIQ:master Jan 15, 2018
@agrare agrare self-assigned this Jan 15, 2018
@agrare agrare added the test label Jan 15, 2018
@agrare agrare added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 15, 2018
simaishi pushed a commit that referenced this pull request Jan 23, 2018
@agrare @simaishi
Merge pull request #123 from felipedf/fixing_tests_hostname
9a21a5d 
Fixing tests for the new hostname validation
(cherry picked from commit f7509d2)
@simaishi
Copy link
Contributor

Backported to Gaprindashvili as ManageIQ/manageiq#16714 was backported.

Gaprindashvili backport details:

$ git log -1
commit 9a21a5df11068d3a85b48f8cb385a69382d8e69c
Author: Adam Grare <[email protected]>
Date:   Mon Jan 15 09:13:21 2018 -0500

    Merge pull request #123 from felipedf/fixing_tests_hostname
    
    Fixing tests for the new hostname validation
    (cherry picked from commit f7509d2fb2f07c0cf899e45473695a542047bbdc)

@simaishi simaishi mentioned this pull request Jan 23, 2018
Merged
@felipedf felipedf deleted the fixing_tests_hostname branch May 4, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
gaprindashvili/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felipedf @miq-bot @simaishi @agrare