-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning faker gem to 1.8.3 #118
Conversation
@jrafanie This ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you include why we're doing it?
faker changed dependency of i18n which conflicts with our dependency from manageiq-consumption:
faker-ruby/faker@9128945#diff-e79a60dc6b85309ae70a6ea8261eaf95R5
@jrafanie Because you said to? 😂 |
faker changed dependency of i18n which conflicts with our dependency from manageiq-consumption: faker-ruby/faker@9128945#diff-e79a60dc6b85309ae70a6ea8261eaf95R5
Checked commit e901c89 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Loool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juliancheal |
Adding In the last build, 1.8.4 was being used. Do we not want to pin at 1.8.4? |
The gemspec had
|
1.8.5 is the problem version so 1.8.4 should be fine to use @juliancheal |
Pinning faker gem to 1.8.3 (cherry picked from commit 7d0ed91)
Gaprindashvili backport details:
|
We can update the dependency on manageiq-consumption, if it is better. |
@chargio It's not mutually exclusive. This change requires no other changes. We can now upgrade manageiq-consumption at our convenience and then decide if we want to loosen the dependency requirement here. |
faker changed dependency of i18n which conflicts with our dependency from manageiq-consumption:
faker-ruby/faker@9128945#diff-e79a60dc6b85309ae70a6ea8261eaf95R5