Add methods for for provider creation pluggable UI #149
Conversation
agrare
force-pushed
the
add_params_for_create_and_verify_credentials
branch
from
c3df2f5 to
6766ad4
Compare
| :name => "endpoints.default.port", | ||
| :type => "number", | ||
| :isRequired => true, | ||
| :validate => [{:type => "required-validator"}] |
There was a problem hiding this comment.
I think there's a validator for numbers.
There was a problem hiding this comment.
You mean for a port range like [1, 65535]? Yeah can add that
agrare
force-pushed
the
add_params_for_create_and_verify_credentials
branch
from
6766ad4 to
e89531c
Compare
| :isRequired => true, | ||
| :validate => [ | ||
| {:type => "required-validator"}, | ||
| {:type => "validatorTypes.MIN_NUMBER_VALUE", |
There was a problem hiding this comment.
Not sure if this is right, @Hyperkid123 ?
There was a problem hiding this comment.
Yes that seems correct.
You can see live example with same use case just different values here if you want to see it live: https://data-driven-forms.org/renderer/validators#numbervaluevalidators
There was a problem hiding this comment.
What's with the => spacing? Didn't realize you were aligning to the stuff after...even so, I think the
{:type => "a",
:value => 1
}is a weird layout, particularly because it introduce the single space...would prefer
{
:type => "a",
:value => 1
}There was a problem hiding this comment.
|
|
||
| def self.verify_credentials(args) | ||
| server, port, token = args.dig("endpoints", "default")&.values_at("server", "port", "token") | ||
| !!raw_connect(:server => server, :port => port, :token => token) |
There was a problem hiding this comment.
Super minor but if the incoming hash already has the keys...this can be simplified to just use slice.
!!raw_connect(args.dig("endpoints", "default")&.slice("server", "port", "token").symbolize_keys)There was a problem hiding this comment.
Also, interestingly, the docs for raw_connect say it takes verify_ssl and ca_certs, but then never uses them? https://github.com/ManageIQ/manageiq-providers-kubevirt/pull/149/files#diff-ff17b05a7c525eec833f0ddb0134a0d9R109-R111
There was a problem hiding this comment.
Yeah I couldn't tell if that was an oversight or not so I left the description for now.
agrare
force-pushed
the
add_params_for_create_and_verify_credentials
branch
2 times, most recently
from
4318df1 to
d6b4f70
Compare
Add a method indicating the properties required to create a Kubevirt provider and implement the common self.verify_credentials interface method. ManageIQ/manageiq#18818
agrare
force-pushed
the
add_params_for_create_and_verify_credentials
branch
2 times, most recently
from
72f3a68 to
02e4ba3
Compare
agrare
force-pushed
the
add_params_for_create_and_verify_credentials
branch
from
02e4ba3 to
8f7439d
Compare
|
Checked commits agrare/manageiq-providers-kubevirt@b1235ac~...8f7439d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Add a method indicating the properties required to create a Kubevirt
provider and implement the common self.verify_credentials interface
method.
ManageIQ/manageiq#18818