Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fixing graph refresh and adding persistor #64

Closed
wants to merge 7 commits into from

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Jul 14, 2017

[WIP] fixing graph refresh and adding persistor

@miq-bot miq-bot added the wip label Jul 14, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 14, 2017

Checked commits Ladas/manageiq-providers-kubernetes@4004c35~...5a40cc6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 3 offenses detected

app/models/manageiq/providers/kubernetes/container_manager/inventory_collections.rb

app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb

  • ❗ - Line 47, Col 9 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

@cben
Copy link
Contributor

cben commented Jul 16, 2017

FYI pushed couple more commits to #57.

@miq-bot
Copy link
Member

miq-bot commented Jul 21, 2017

This pull request is not mergeable. Please rebase and repush.

@Ladas
Copy link
Contributor Author

Ladas commented Jul 25, 2017

closed in favor of #73

@Ladas Ladas closed this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants