Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ManagerRefresh to InventoryRefresh #282

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Move ManagerRefresh to InventoryRefresh #282

merged 1 commit into from
Sep 11, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 7, 2018 •
edited
Loading

Move ManagerRefresh to InventoryRefresh

Depends on:

@miq-bot
Copy link
Member

miq-bot commented Sep 7, 2018

Checked commit agrare@5565f37 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍰

@cben
Copy link
Contributor

cben commented Sep 8, 2018

Tests fail, uninitialized constant ManageIQ::Providers::Kubernetes::ContainerManager::RefresherMixin::InventoryRefresh

@agrare
Copy link
Member Author

agrare commented Sep 9, 2018

@cben yeah we need the core PR merged first

@agrare agrare mentioned this pull request Sep 10, 2018
Merged
8 tasks
@agrare agrare closed this Sep 10, 2018
@agrare agrare reopened this Sep 10, 2018
@Fryguy Fryguy self-assigned this Sep 11, 2018
@Fryguy Fryguy merged commit bf65941 into ManageIQ:master Sep 11, 2018
@Fryguy Fryguy added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 11, 2018
@agrare agrare deleted the rename_manager_refresh_to_inventory_refresh branch September 11, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @cben @Fryguy