Set EmsEvent ems_ref to event's uid, to avoid same-second collision #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmsEvent.create_event drops "duplicate" events, determined by (event_type, timestamp, chain_id, ems_id, ems_ref). Container events had no ems_ref (and no chain_id), meaning events of same type in same second collided and only one EmsEvent was created. The lost events weren't handled by Automate / Policy. Using k8s event's uid, not involvedObject's uid which still wouldn't be unique (for repeating events on same object). https://bugzilla.redhat.com/show_bug.cgi?id=1583832
|
Checked commit cben@6d1cb2c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM 👍 |
moolitayer
approved these changes
Jun 25, 2018
|
@cben I see you want to test on Gaprindashvili before we merge so I'm not merging. |
|
Let's merge but not backport?
for master, I'm confident it's the right fix.
пн, 25 июн. 2018 г., 10:23 Mooli Tayer <[email protected]>:
… @cben <https://github.com/cben> I see you want to test on Gaprindashvili
before we merge so I'm not merging.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#264 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQtGL2lYTJJGvA06JV0LxjjWQKUD1pOks5uAI_VgaJpZM4U1T86>
.
|
|
@simaishi Applies cleanly to gaprindashvili, tested there too, clear for backporting. |
simaishi
pushed a commit
that referenced
this pull request
Jun 27, 2018
Set EmsEvent ems_ref to event's uid, to avoid same-second collision (cherry picked from commit 9ee6118) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1595324
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1583832
@miq-bot add-label bug, events, gaprindashvili/yes
EmsEvent.create_event drops "duplicate" events, determined by (event_type, timestamp, chain_id, ems_id, ems_ref).
Container events had no ems_ref (and no chain_id), meaning events of same type in same second collided and only one EmsEvent was created.
The lost events weren't handled by Automate / Policy.
Using k8s event's uid, not involvedObject's uid which still wouldn't be unique (for repeating events on same object).
4 EmsEvents created, with same timestamp and different ems_ref and.
@elad661 @moolitayer please review