Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use the ImageAcquireError field #222

Conversation

enoodle
Copy link

@enoodle enoodle commented Jan 23, 2018

Due to changes in [1], the field ImageAcquireSuccess is not being used anymore

[1] openshift/image-inspector#82

@enoodle
Copy link
Author

enoodle commented Jan 23, 2018

@moolitayer PTAL this is a small one liner fix for a shortcoming of #174

Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@enoodle enoodle force-pushed the image_scanning_update_image_acquiring_error_handling branch from dad7ea9 to 3099f78 Compare January 28, 2018 17:21
@miq-bot
Copy link
Member

miq-bot commented Jan 28, 2018

Checked commit enoodle@3099f78 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moolitayer
Copy link

@enoodle labels plz

@moolitayer moolitayer merged commit 070e98e into ManageIQ:master Jan 28, 2018
@moolitayer moolitayer added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 28, 2018
@moolitayer moolitayer self-assigned this Jan 28, 2018
@enoodle
Copy link
Author

enoodle commented Jan 29, 2018

@miq-bot add_labels smartstate bug

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2018

@enoodle Cannot apply the following label because they are not recognized: gaprindashvili/yes smartstate

@cben
Copy link
Contributor

cben commented Jan 29, 2018

@enoodle hmm your comment is different from what miq-bot complained about, so will leave to you to set right labels.

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2018

@enoodle Cannot apply the following label because they are not recognized: smartstate bug

@enoodle
Copy link
Author

enoodle commented Jan 29, 2018

Yes, I don't want gaprindashvili, it was a mistake.

@enoodle
Copy link
Author

enoodle commented Jan 29, 2018

@miq-bot add_labels bug

@miq-bot miq-bot added the bug label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants