-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for parse_pod, specifically for STI type if missing pod status #194
Conversation
Checked commit cben@1c8e2a6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Tests for parse_pod, specifically for STI type if missing pod status (cherry picked from commit 2df4967) https://bugzilla.redhat.com/show_bug.cgi?id=1524630
Gaprindashvili backport details:
|
Followup to #177. As discussed there, testing actual
type
set in DB in refresher_spec might be best, but it turned out harder than I thought to capture pods without status in VCR. A pod with bad image does get a status, withwaiting
state. (Maybe requesting resources above quota to keep it pending would work?)Instead, I captured various states a pod goes through from
oc get pods --watch --show-all --all-namespaces -o json
into refresh_parser_spec.(Tip:
jq 'select((.spec.containers | length) > (.status.containerStatuses | length))'
finds states with missing statuses.)We already have some tests for parse_container_status/state, but the bug here
Wasn't sure what to test, for now included all states but only tested STI types.
Verified test failed before #177:
https://bugzilla.redhat.com/show_bug.cgi?id=1517676
@miq-bot add-labels inventory, test, gaprindashvili/yes
@zeari @enoodle @moolitayer please review
(not cc'ing Ladas because holidays)