Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parser: Collect all mapped tags that need resolving #117

Closed
wants to merge 1 commit into from

Conversation

cben
Copy link
Contributor

@cben cben commented Sep 25, 2017

Overview issue: #126

This will allow separating creating/finding them from reassiging them: ManageIQ/manageiq#16029
which will help implement tag mapping in graph refresh.

@miq-bot add-label enhancement

@zgalor @moolitayer @Ladas Please review.
cc @djberg96

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2017

Checked commit cben@2ce4ff1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@cben
Copy link
Contributor Author

cben commented Oct 1, 2017

@miq-bot add-label wip
Exploring using InventoryCollection instead of hashes for both old and graph refresh — this will be mostly contained in ContainerLabelTagMapping and this PR will almost disappear.

@miq-bot miq-bot changed the title Parser: Collect all mapped tags that need resolving [WIP] Parser: Collect all mapped tags that need resolving Oct 1, 2017
@miq-bot miq-bot added the wip label Oct 1, 2017
@cben cben changed the title [WIP] Parser: Collect all mapped tags that need resolving Parser: Collect all mapped tags that need resolving Oct 15, 2017
@cben cben changed the title Parser: Collect all mapped tags that need resolving [WIP] Parser: Collect all mapped tags that need resolving Oct 15, 2017
@cben
Copy link
Contributor Author

cben commented Oct 15, 2017

Closed in favor of #130

@cben cben closed this Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants