Update PowerVS cloud subnet parser

[jaywcarman]

• Add AZ relationship
• Save network type to 'extra_attributes' column

[agrare]

Looks good @jaywcarman can you add a check in the assert_specific_cloud_subnet spec? Something like expect(cloud_subnet.availability_zone&.ems_ref).to eq(ems.uid_ems)

[jaywcarman]

@agrare Should I store this as a hash {'type' => network['type']} ?

We weren't using it before, but this is in our current refresher spec:
https://github.com/ManageIQ/manageiq-providers-ibm_cloud/blob/master/spec/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/refresher_spec.rb#L152

[jaywcarman]

Do all extra attributes passed to persister.cloud_subnets.build automatically get added to the cloud_subnets extra_attributes DB column?

[agrare]

That's interesting, wasn't aware of this but we define some accessor methods that use extra_attributes as the backing: https://github.com/ManageIQ/manageiq/blob/master/app/models/cloud_subnet.rb#L35-L43
so cloud_subnet.ip_version= gets saved to extra_attributes

In this case maybe it is best to define a network_type= which saves it to extra_attribtues

I learn something new in this huge product everyday

[jaywcarman]

:) I know the feeling, that's for sure! I was very confused as to how the specs were passing without any existing extra_attributes, haha.

I agree with defining cloud_subnet.network_type= so we can keep ip_version. I've noticed the providers are inconsistent on using IPv4 vs ipv4 for network protocol so I could see it being useful.

[jaywcarman]

ManageIQ/manageiq#20672

[miq-bot]

Checked commit jaywcarman@61d8eec with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[jaywcarman]

Cross repo test with ManageIQ/manageiq#20672 is passing:
ManageIQ/manageiq-cross_repo-tests#188

[agrare]

👍 awesome @jaywcarman !