Force bundler to the latest version on Ruby 3.1 #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that our cache sizes were growing enormously, namely in the git repositories, where the git directory is not git gc'd. The bundler shipped with Ruby 3.1, bundler 2.3.27, exhibits the problem, whereas newer bundlers > 2.4.0 seem to have mitigated the problem because of the underlying change to how git respositories are shallow clones.
Fryguy
commented
Nov 21, 2024
| @@ -37,6 +37,7 @@ jobs: | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| ruby-version: "${{ matrix.ruby-version }}" | |||
| bundler: "${{ matrix.ruby-version == '3.1' && 'latest' || 'default' }}" | |||
There was a problem hiding this comment.
Alternatively, I could just set it to latest for everything, but I worry that we won't follow up with a removal when we drop 3.1. This way we can't miss it. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that our cache sizes were growing enormously, namely in the git repositories, where the git directory is not git gc'd. The bundler shipped with Ruby 3.1, bundler 2.3.27, exhibits the problem, whereas newer bundlers > 2.4.0 seem to have mitigated the problem because of the underlying change to how git respositories are shallow clones.
@agrare Please review.