This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
Adds support to middleware threshold and web sessions conditions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucasponce can you take a look? |
|
Technically the PR looks good, but I've made some comments on ManageIQ/manageiq#16113 that might affect to this PR in those are accepted. |
josejulio
force-pushed
the
support_for_web_threshold_conditions
branch
from
97094a5 to
45a5779
Compare
|
Checked commit josejulio@45a5779 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/hawkular/middleware_manager/alert_manager.rb |
|
Superseded by #68 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by ManageIQ/manageiq#16113 to generate the conditions.
https://issues.jboss.org/browse/HAWKULAR-1255