This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
Changing bracket syntax for method/attribute syntax in update_alerts #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method update_alerts receives a MiqAlert. It was accessing attributes using brackets [] syntax. However, MiqAlert#expression attribute was renamed in the database and the brackets syntax no longer works for this attribute; it is now a method. Changing reads to attributes to use method/attribute-like syntax instead of brackets [] syntax.
|
@miq-bot add_label alerts, bug, fine/no |
|
Checked commit israel-hdez@f854583 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of:
Usage of
alert[:expression]no longer works. Changing everything to use method/attribute accessors.