Delegate endpoints and authentications on managers to the provider #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @skateman yes anything that we delegate in the config manager we should also delegate int he provisioning manager |
skateman
changed the title
skateman
force-pushed
the
delegate-endpoint-auth
branch
from
60cd5e0 to
f5078f7
Compare
skateman
force-pushed
the
delegate-endpoint-auth
branch
from
f5078f7 to
cf01648
Compare
3 tasks
|
Checked commit skateman@cf01648 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
agrare
approved these changes
Mar 31, 2020
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to ask for the endpoints/authentications the same way through the API as we do with other providers.
@agrare should we also do this delegation in the prov manager?
Parent issues:
ManageIQ/manageiq#18818
ManageIQ/manageiq#19992